Replace arm64 for aarch64 in ::apt::source#1012
Merged
LukasAud merged 1 commit intopuppetlabs:mainfrom Feb 7, 2022
Merged
Conversation
|
|
apt::source is a typethat may have no external impact to Forge modules. This module is declared in 233 of 578 indexed public
|
LukasAud
approved these changes
Feb 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
arm64is a rather new player in the server market: AWS Gravitron instances use it, but it is also used when running Linux-based VMs on Apple's new M1 chips.As someone explained on StackOverflow, the Linux Kernel uses
aarch64at the name for this architecture, and that's what is reported by Facter.Apt, however, uses the
arm64architecture name for this platform.This mismatch can cause bugs as in puppetlabs/docker, and thus my suggestion is to fix it here in a central location.
I am not familiar with Ruby programming and rspec-based acceptance tests. So, if that's a requirement for getting this merged, any help is greatly appreciated.